Add two activities consecutive

[math]

Here's a teeny tiny improvement suggestion:
When adding the constraint "Add two activities consecutive", the constraint window opens up with "First activity" and "Second activity" preselected as first activity of the first teacher. By selecting a different teacher, the preselection of the fields "First activity" and "Second activity" change to the first activity of the selected teacher.

Wouldn't it make more sense to preselect the second activity of the teacher in the field "Second activity"? Selecting the same activity in both fields is an impossible selection, so selecting the second activity of the teacher would result in a valid selection at least.

[Liviu Lalescu]

Thank you for your suggestion! However, I prefer the current mode of operation:

- I consider better that the user gets warned that the constraint is invalid because the activities are the same, so he does not forget to change them.
- Maybe the filter has only 1 activity.

I will add your suggestion in the TODO.

[math]

Hi Liviu!

Thanks for considering my suggestion. If there is only one activity, it's clearly impossible the select any second activity. Sorry for causing confusion if you understood me that way.

However, if there is a second activity, I would clearly prefer that FET chooses that one automatically. If you're aiming at forcing the user to change fields for not forgetting it, you would otherwise have to set values in other dialoges to impossible values as well (e.g. weight of constraints).

Best, Matthias

[Liviu Lalescu]

Thanks for considering my suggestion. If there is only one activity, it's clearly impossible the select any second activity. Sorry for causing confusion if you understood me that way.

No, sorry, I meant that your suggestion cannot be always applied, resulting in a non-uniform treatment, in my opinion. But it is a minor thing.

However, if there is a second activity, I would clearly prefer that FET chooses that one automatically. If you're aiming at forcing the user to change fields for not forgetting it, you would otherwise have to set values in other dialoges to impossible values as well (e.g. weight of constraints).

My preferred behavior is in the add activity dialog (subject not selected), in activities occupy min/max time slots and min/max simultaneously (0 slots selected, value 0 selected), when adding virtual rooms, and maybe in other places.

Hmm... I am not sure. I am planning an official release right now, maybe I will rethink.

[Liviu Lalescu]

I just did as you suggested. FET-6.1.3 was just released (a few minutes ago). Thank you!

[math]

Thanks a lot! 

[Liviu Lalescu]