Days of week

[math]

I just discovered something that I wouldn't actually call a bug, but it's a little odd. It's about the "Data -> Basic -> Days and hours -> Days per week" dialogue.

• When deleting elements in other windows FET always asks for a confirmation. This dialogue is a little different because hitting the "remove" button directly removes the selected element without asking anything.
• On the upper right corner of that dialog the number of days is displayed. Hitting the "arrow down" beside that number field is equivalent with hitting the "remove" button. Hence, the selected element is removed without requiring any confirmation.
• Hitting the "up arrow" beside that number field does not compensate hitting the "down arrow". Clicking the up arrow increases the number of days, but it does not restore the content of the removed day.
• Let's remove all the days, so that there is only just one day left. If you never changed the day names, this remaing day will be named "Day 1". Now click the "insert" button. The existing "Day 1" will be moved to the second position, the first position will be a new day, also called "Day 1".
• Clicking the "insert" button seems to have a "add adove" semantic while clicking the "arrow up" button beside the number field has a "add below" semantic. I think that both semantics are required in such a dialog and it should be easier to identify which button needs to be clicked (maybe adding to "insert" buttons "insert above" and "insert below"?)
• In other dialogs the button for appending elements is always named "add". Here it is "insert".
• When opening up the dialogue no day is selected. When clicking the "remove" button an error message pops up: "Invalid selected day". Is this really a good error message? There is no selected day, so how can it be invalid? Shouldn't it rather be something like "Please select a day to be deleted"?
• There does not seem to be a length limitation for the names of the day. So even adding overly long names is working. The overly long name is displayed in multiple lines of that table. So let's add a name with an overly long name with 250.000 chars. Now select Timetable -> Generate for generating a new timetable. Finally Timetable -> Students -> Days horizontally (or any other timetable) for displaying the timetable. FET crashes immediately.

[Liviu Lalescu]

Thank you for the report:

1. You can click Cancel at any moment.
2. See 1.
3. This is the best design I could do.
4. Also if there is Day2 and you press twice. See 3.
5. Insert inserts, up arrow adds at the end. I cannot think of a better way.
6. It is not append, it is insert.
7. I think in many other places in FET I think I did like this. But I'll think about it.
8. I think in many other places like that FET can crash. I cannot think of all things like this, unfortunately.

[Liviu Lalescu]

I "solved" 7. : I select the first day/hour when opening the dialog.

[math]

Thanks a lot! And please excuse if my bug report was offending in any way. That was not my intention. I just thought that this dialog works a little different than all the other dialogs. At the bottom line FET is an full featured powerhorse. Thanks for all the effort you put into this software!

[Liviu Lalescu]

You are welcome, and thank you! 

Of course no ofence 

This dialog was realized recently, in FET-6.0.0. So it is different from the old dialogs.