FET Forum

FET Development => Suggestions => Topic started by: Mr Robo on March 11, 2012, 02:47:51 PM

Title: Missing en_GB locale?
Post by: Mr Robo on March 11, 2012, 02:47:51 PM
Hi

We use the html form of timetable directly from FET, so it would be good if the date format could use the British locale of dd/mm/yy rather than mm/dd/yy.

Digging in the code reveals that the default locale has been changed to en_US from en_GB (a retrograde step in every imaginable dimension!) at some point in the past.

I changed the default in the source back to en_GB and nothing untoward happened. The date is displayed correctly now!

I'm happy to provide a en_GB translation if en_US has to be the default, but I can't see why it has to be in the code.

Best Wishes

Nick

Title: Re: Missing en_GB locale?
Post by: Liviu Lalescu on March 11, 2012, 03:22:09 PM
Quote from: Mr Robo on March 11, 2012, 02:47:51 PM
Hi

We use the html form of timetable directly from FET, so it would be good if the date format could use the British locale of dd/mm/yy rather than mm/dd/yy.

Digging in the code reveals that the default locale has been changed to en_US from en_GB (a retrograde step in every imaginable dimension!) at some point in the past.

Dear Nick,

Indeed, I used en_GB as default in the beginning. Why? Because I looked on KDE translations languages and for English this was the only one. So I thought this was the default. But it turned out that for KDE en_US is the default. Also for Qt, en_US is default. So, there is no en_US translation file. There may be an en_GB translation file, if provided.

Also, I think I am using the American English myself (I am not sure, in school I learned British, but computer language maybe affected me.) I am using for instance "center" and "color".

Quote
I changed the default in the source back to en_GB and nothing untoward happened. The date is displayed correctly now!

This is true.

Quote

I'm happy to provide a en_GB translation if en_US has to be the default, but I can't see why it has to be in the code.

en_GB should come with a separate translation file, and en_US not. This is what Qt, KDE and maybe many other systems say. I personally don't have any preference, it is others who settle the direction (also in Romanian we have dd/mm/yy, so month first is unnatural for me.)

OK, we may add an en_GB file. This will increase a bit the archive size, but it is a good addition. Also, I would prefer to supervise every change, so there should not be too many changes. Also, all identical strings should remain untranslated. Hmm, maybe I could even not ask to supervise all the file.

Quote

Best Wishes

Nick
Title: Re: Missing en_GB locale?
Post by: Liviu Lalescu on July 20, 2017, 03:38:15 PM
Hello,

Starting with FET-5.32.0, I added the en_GB locale (Settings->Language).

Please forgive me for not giving you credits for this suggestion, but only now, after the release, I found this topic. I will add your credits in the next version.