Hi Guys, I would like to report some typos in the source code :)
I: fet: spelling-error-in-binary usr/bin/fet adviced advised
N:
N: Lintian found a spelling error in the given binary. Lintian has a list
N: of common misspellings that it looks for. It does not have a dictionary
N: like a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help
N: of gettext or a similar tool, please fix the error in the translations
N: as well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling
N: mistake in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Severity: minor, Certainty: wild-guess
N:
N: Check: binaries, Type: binary, udeb
N:
I: fet: spelling-error-in-binary usr/bin/fet splitted split
I: fet: spelling-error-in-binary usr/bin/fet explicitely explicitly
I: fet: spelling-error-in-binary usr/bin/fet-cl adviced advised
and another issue:
I: fet: desktop-entry-lacks-keywords-entry usr/share/applications/fet.desktop
N:
N: This .desktop file does either not contain a "Keywords" entry or it does
N: not contain any keywords not already present in the "Name" or
N: "GenericName" entries.
N:
N: .desktop files are organized in key/value pairs (similar to .ini files).
N: "Keywords" is the name of the entry/key in the .desktop file containing
N: keywords relevant for this .desktop file.
N:
N: The desktop-file-validate tool in the desktop-file-utils package is
N: useful for checking the syntax of desktop entries.
N:
N: Refer to
N: http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html,
N: https://bugs.debian.org/693918, and
N: https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords for
N: details.
N:
N: Severity: wishlist, Certainty: certain
N:
N: Check: menu-format, Type: binary
N:
you can see them here http://debomatic-amd64.debian.net/distribution#unstable/fet/5.27.8-1/lintian
and google for the lintian warning to see the extended description :)
let me know if you need help!
cheers,
Gianfranco (who just uploaded the new fet on Debian)
Thank you!
Could you send me a corrected .desktop file? I don't know how to add keywords.
I think I will correct typos and hopefully release a new version soon.
Edited to add: should I add keywords for all the languages listed under Name and Comments? I don't know how to do that. Also, I don't know what other keywords to add besides the Name and Comments words.
If you can, please check the latest snapshot on http://lalescu.ro/liviu/Backup-fet/ and tell me if I solved the typos.
Hi, I guess the keyword missing is
"Keywords"
https://www.google.it/search?client=ubuntu&channel=fs&q=keywords+filetype%3Adesktop&ie=utf-8&oe=utf-8&gfe_rd=cr&ei=c7vxVYakGanD8gf2xYr4BA
:)
cheers,
G.
Yes, but I cannot let it empty. In this case, I don't know what more keywords different from Name and Comments to add. Also, I cannot add keywords in other languages.
Keywords=education,student,school,pupil,time,table
.etc.
Maybe these: education, teacher, student, school, high-school, university (maybe only the first three).
But how to add the translation of these into other languages (like in the attached file)? Add only the default US English?
maybe:
timetable, schedule, planning, school, high-school, university, education, teacher, students, principal
Quote from: Liviu Lalescu on September 10, 2015, 07:18:53 PM
But how to add the translation of these into other languages (like in the attached file)?
Translators will translate later.
Quote from: Liviu Lalescu on September 10, 2015, 07:18:53 PM
Add only the default US English?
Yes
Sorry, the desktop file actually comes from Debian, not from Upstream... :)
https://anonscm.debian.org/cgit/collab-maint/fet.git/tree/debian/fet.desktop
well you might want to start from there and add some english keywords...
(not too many, just 4-5 keywords are fine!)
thanks a lot!
OK, I added some keywords, please check the attached file.
wonderful! you rock!
Thank you for your bug reports!
I will release a new version, but I don't know how soon. Now it is a kind of critical period, many users are downloading and using before school start.
Maybe you could test the new version (from the link above: http://lalescu.ro/liviu/Backup-fet/ , and replace fet.desktop with the file from my previous post) to check that the warnings are gone. But only if you have enough spare time.
actually I can wait for the new release, they aren't important warnings, and the version is not even in Debian unstable
(it is in the new queue)
cheers!
G.
I have released the new version. Thank you for your reports!
Updating it right now, thanks!
Does it compile amd64 only. I couldn't find it in i386. (maybe it just need some time?)
I also wonder about the building log file:
dpkg-gencontrol: warning: File::FcntlLock not available; using flock which is not NFS-safe
What does that mean? (I saw it while compiling and viewing the log.)
hmmm... I can see this:
6m27.2s ERROR: Installation of fet failed
6m27.2s ERROR: Installation of fet-data failed
6m27.2s ERROR: Could not install fet-data fet.
6m30.3s ERROR: piuparts run ends.
Is there somewhere more information? I don't know how to fix that.
In the detailed build log are some more warnings. Any idea how to fix them?
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/fet/usr/bin/fet debian/fet/usr/bin/fet-cl were not linked against libpthread.so.0 (they use none of the library's symbols)
dpkg-gencontrol: warning: File::FcntlLock not available; using flock which is not NFS-safe
dpkg-genchanges: warning: 'since' option specifies non-existing version
dpkg-genchanges: warning: use newest entry that is earlier than the one specified
I saw you recompiled. Looks better now (less warnings). I hope you can fix also the other warnings. Maybe, after you are successful and if you have a bit time, let me know how you use Deb-o-Matic and how you solved the warnings.
Hi, nothing to worry about, DebOMatic is a service where we upload build tries, so I did just upload a version for testing on amd64.
I uploaded right now a new version, that will be likely be the one in the archive.
Piuparts seems to be giving a problem in -data package, but I guess this is a false positive
the only real warning is:
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/fet/usr/bin/fet debian/fet/usr/bin/fet-cl were not linked against libpthread.so.0 (they use none of the library's symbols)
I guess you want to fix it, you link pthread but you don't use symbols of it.
You use QThread, and it should already link threads internal
(or I could use wl-asneeded flag to strip it :) )
I did as in the attached files, maybe you can test: overwrite and compile again. But I am not sure this will solve the warning, as fet and fet-cl still require threading.
Maybe the problem is in generation.cpp.
stuff like
extern QMutex myMutex;
is used by fet, but not fet-cl.
so that stuff must not be compiled with fet-cl?!
I don't know, the patch doesn't solve the issue, but we can just not care, it is a useless warning, and the package is already in the new queue :)
Quote from: locutusofborg on September 14, 2015, 01:09:39 PM
I don't know, the patch doesn't solve the issue, but we can just not care, it is a useless warning, and the package is already in the new queue :)
OK, sure.