FET Forum

FET Development => Suggestions => Topic started by: math_user on July 16, 2016, 08:48:22 AM

Title: customizable values for width and height (css file) in the settings
Post by: math_user on July 16, 2016, 08:48:22 AM
It would be great if the user could change the default values for width and height (disabled and 8ex) in the settings: enable/disable and enter values (default: 8 and 8).
Like that, the user does not have to change the values manually after each generation.
Title: Re: customizable values for width and height (css file) in the settings
Post by: Liviu Lalescu on July 16, 2016, 06:15:56 PM
I will add this in the TODO list.

But there are too many possible settings like this. We cannot care about them all.
Title: Re: customizable values for width and height (css file) in the settings
Post by: math_user on July 18, 2016, 04:58:36 PM
QuoteBut there are too many possible settings like this. We cannot care about them all.
Yes.

Maybe just uncomment "width" in the css file?
th.xAxis {
  width: 8em;
}

th.yAxis {
  height: 8ex;
}

instead of
th.xAxis {
/* width: 8em; */
}

th.yAxis {
  height: 8ex;
}


I think that the (minimal) width is useful. Like this I can easily change the default values 8em and 8ex. Uncommenting is a bit tedious ...
Title: Re: customizable values for width and height (css file) in the settings
Post by: Liviu Lalescu on July 18, 2016, 05:56:47 PM
I don't know if it is good. Volker knows better. But I think we should keep timetables small.
Title: Re: customizable values for width and height (css file) in the settings
Post by: math_user on July 18, 2016, 07:41:45 PM
Maybe

th.xAxis {
  width: 4em;
}


or

th.xAxis {
  width: 2em;
}


?
Title: Re: customizable values for width and height (css file) in the settings
Post by: Volker Dirr on July 18, 2016, 07:55:12 PM
the disadvantage if small yAxis is, that many teachers read the table incorrect if the hours are on the yAxis.
if the teacher have got several unused timeslots, then it is very difficult to see if it has got duration 1,2 or 3. it look nearly the same.
especially on the large tables in the teacher room. you can't read those tables without a long ruler then.
but with a larger y-Axis you can just read them by looking. in worst case by using your finger. (You can't do that on long tables with 50 teachers, you will jump into the wrong row then.

if you think that is better, you can just change it in the source and compiler yourself. so you will never need to change the css file yourself.
Title: Re: customizable values for width and height (css file) in the settings
Post by: Liviu Lalescu on July 18, 2016, 08:16:01 PM
Volker, I am not sure I understand. We are talking about xAxis, not yAxis, and increasing it, not decreasing. But I am sure you know better, because it is your part. Maybe you could show us some screen shots to explain.

math user, if you want to modify the sources, it is in timetableexport.cpp, line 2256.
Title: Re: customizable values for width and height (css file) in the settings
Post by: math_user on July 18, 2016, 08:31:38 PM
Quotemath user, if you want to modify the sources, it is in timetableexport.cpp, line 2256.
Thanks, Liviu!
Title: Re: customizable values for width and height (css file) in the settings
Post by: Volker Dirr on July 18, 2016, 10:08:17 PM
ah.. sorry, i didn't read carefully enough.
Title: Re: customizable values for width and height (css file) in the settings
Post by: Liviu Lalescu on July 19, 2016, 06:50:44 AM
So, what should we do? How is better? Should we uncomment the "width 8em;"?
Title: Re: customizable values for width and height (css file) in the settings
Post by: Volker Dirr on July 19, 2016, 07:01:47 AM
but the xAxis is very easy to handle. You just "need" to write longer names. So if you have got days on xAxis, just write "Monday" instead of "Mo". Or just use longer subject names instead of shortcuts.
Title: Re: customizable values for width and height (css file) in the settings
Post by: Volker Dirr on July 19, 2016, 07:07:05 AM
or, if you have hours on the xAxis don't write hour "1", "2", ... Write times like "08:00 - 08:45", "08:50 - 09:35", ...
so the xAchis is very easy to handle indirectly.
Title: Re: customizable values for width and height (css file) in the settings
Post by: Liviu Lalescu on July 19, 2016, 07:12:01 AM
It is easier for us to make a change in the code, but only if it is a good change.

In the attached screen shots, it is clear that it is nicer with uncommented width (as math user suggests). But I am not sure in other timetables, or maybe some users would like smaller dimension.
Title: Re: customizable values for width and height (css file) in the settings
Post by: Volker Dirr on July 19, 2016, 07:20:05 AM
please check a teacher with a free day and a shortcut as day.
or if you swap axis:
check a timetable with a break at a special hour (all days) and a shortcut as hour name.
Title: Re: customizable values for width and height (css file) in the settings
Post by: Liviu Lalescu on July 19, 2016, 07:33:30 AM
OK, I didn't check this, but I understand.
Title: Re: customizable values for width and height (css file) in the settings
Post by: Liviu Lalescu on July 19, 2016, 07:46:45 AM
Quote from: Volker Dirr on July 19, 2016, 07:20:05 AM
please check a teacher with a free day and a shortcut as day.
or if you swap axis:
check a timetable with a break at a special hour (all days) and a shortcut as hour name.

So, math user, these are reasons not to operate your suggestion in the official FET. Of course you can have your custom modified FET.