FET Forum

FET Development => Suggestions => Topic started by: Liviu Lalescu on February 07, 2020, 05:36:25 PM

Title: fet-cl --version - should write or not the information in a log file?
Post by: Liviu Lalescu on February 07, 2020, 05:36:25 PM
Currently, if you run "fet-cl --version" it makes a directory "logs" and writes there a "result.txt" file with this information (in addition to the information output on the terminal).

Is this a wrong behavior, and it should only write to the terminal?
Title: Re: fet-cl --version - should write or not the information in a log file?
Post by: Zsolt Udvari on February 08, 2020, 02:00:37 PM
I think it's enough write only to terminal.

But one suggestion: the fet --help is hard to read. I think would better similar as:

Usage: fet-cl --inputfile=FILE [other options]

Other options are:
--outputdir=DIR             the path to results directory, without trailing slash or backslash (default is current working path). Make sure you have write permissions there.
--timelimitseconds=NUM      the time limit in seconds  (default 2000000000, which is practically infinite)
...
Title: Re: fet-cl --version - should write or not the information in a log file?
Post by: Liviu Lalescu on February 08, 2020, 07:56:39 PM
Thank you for your valuable suggestions!

I improved the fet-cl usage using your approach, but not identical. I hope you'll like it. Please get the latest (private) snapshot and let me know as soon as possible if it is OK. Temporary location: https://lalescu.ro/liviu/Backup-fet/ (only tar.bz2 for now).

About writing only to the terminal: unfortunately, things are a bit more complicated. I kept things as they were. I will think about it.
Title: Re: fet-cl --version - should write or not the information in a log file?
Post by: Zsolt Udvari on February 09, 2020, 07:10:12 AM
Quote from: Liviu Lalescu on February 08, 2020, 07:56:39 PM
I improved the fet-cl usage using your approach, but not identical. I hope you'll like it.
Yes, it's more better. Thanks! :)
Title: Re: fet-cl --version - should write or not the information in a log file?
Post by: Liviu Lalescu on February 09, 2020, 09:07:44 AM
You are welcome! Thank you for your suggestion!
Title: Re: fet-cl --version - should write or not the information in a log file?
Post by: Liviu Lalescu on February 09, 2020, 11:43:33 PM
Zsolt, I added a new version (see the Snapshots announcement), could you check it please? I don't create a new directory/file unless beginning generation, and other minor improvements. Check that command-line works OK in some tests.
Title: Re: fet-cl --version - should write or not the information in a log file?
Post by: Zsolt Udvari on February 14, 2020, 08:41:34 AM
I think it's okay :)