Text only | Text with Images

FET Forum

FET Support (English) => General Stuff => Topic started by: crow on February 22, 2021, 05:46:01 AM

Title: Categories again!
Post by: crow on February 22, 2021, 05:46:01 AM
22 February 2021

Hi Liviu

Its me and categories again.
I have discovered that if I create, say two categories for a grade
and decide (for some or other reason) to delete both categories,
FET WILL NOT ALLOW me to erase/remove the last category.

Is this a bug?

Eric
Title: Re: Categories again!
Post by: Liviu Lalescu on February 22, 2021, 11:37:54 AM
Hello, Eric,

Thank you for your report!

Yes, this is a bug, but it is very tricky to fix. I tried to fix it, but the dialog is ugly if I allow 0 categories. It is very error-prone and I am afraid to change working code.

You can simply go to the groups dialog and remove all the groups in this year.

I might try some more, but I am not sure. I will let you know if I succeed.

I will add this in the TODO for now.
Title: Re: Categories again!
Post by: crow on February 22, 2021, 01:30:05 PM
22/2/2021

Thanks Liviu for your prompt response.
I will use the workaround.

Eric
Title: Re: Categories again!
Post by: Liviu Lalescu on February 22, 2021, 04:55:35 PM
Hello again, Eric,

I thought about it and I implemented your request. Please get the latest snapshot from https://lalescu.ro/liviu/Backup-fet/ (for now) and please test it thoroughly, trying to find bugs.

I intend to release a new version in about 3-4 days, so please let me know before that.
Title: Re: Categories again!
Post by: crow on February 23, 2021, 04:41:55 AM
Hi Liviu

Will do!

Eric
Title: Re: Categories again!
Post by: Liviu Lalescu on February 23, 2021, 08:20:19 AM
Hello again, Eric,

I made some minor improvements in that dialog, maybe you could have the time to test again a bit: https://lalescu.ro/liviu/Backup-fet/
Title: Re: Categories again!
Post by: crow on February 23, 2021, 12:55:59 PM
Hi Liviu

I at it!

Eric

Title: Re: Categories again!
Post by: crow on February 23, 2021, 02:22:49 PM
Hi Liviu

The change works well, in both versions that you sent me.

Just note the difference in the two diagrams.
Or am I just nitpicking?

Thanks

Eric
Title: Re: Categories again!
Post by: Liviu Lalescu on February 23, 2021, 02:29:24 PM
Hi, Eric, thank you for testing!

It is OK, because if you have 0 categories FET will consider this year empty and add automatically a group and a subgroup in it. Please generate with an empty year and see the students' timetable.
Title: Re: Categories again!
Post by: crow on February 24, 2021, 03:34:36 AM
Hi Liviu

The timetable generates just fine with a grade that has no categories. In the Data, Activities, Add , no categories are shown, as expected.

However, I just find the line in your last post a bit confusing. Please see the attachment.

Thanks

Eric
Title: Re: Categories again!
Post by: Liviu Lalescu on February 24, 2021, 07:17:10 AM
Oh, not here, but generate the timetable and see the students' timetable. FET will add "Automatic Group" and "Automatic Subgroup" for an empty year.
Title: Re: Categories again!
Post by: crow on February 24, 2021, 08:16:09 AM
Hi Liviu

Its doing exactly that!

Thanks Liviu.

Eric
Title: Re: Categories again!
Post by: Liviu Lalescu on February 24, 2021, 10:04:14 AM
Thank you, Eric!  :)
Text only | Text with Images