FET Forum

FET Development => Report a Bug => Topic started by: Željko Vrabec on April 29, 2025, 05:05:32 PM

Title: Separate hours' names and long names by a new line
Post by: Željko Vrabec on April 29, 2025, 05:05:32 PM
Hi guys!

It seems that in version 7.1.8 option Separate hours' names and long names by a new line doesn't do what it suppose to. In some of previous versions it worked just fine.

Cheers!
Title: Re: Separate hours' names and long names by a new line
Post by: Liviu Lalescu on April 29, 2025, 05:34:47 PM
Thank you, Zeljko,

It is a typo. It never worked correctly, I think. I use the setting from the days also for hours. So, until the release, please enable the option for days.

I might put a snapshot for you to check, but I am not sure. I am not home. I will release the final version when home (in 3-5 days maybe). Please tell me, do you only need the tar.bz2 to test?
Title: Re: Separate hours' names and long names by a new line
Post by: Željko Vrabec on April 29, 2025, 05:38:25 PM
Hi Liviu!

Yes tar.bz2 is ok. I build package myself anyway
Title: Re: Separate hours' names and long names by a new line
Post by: Liviu Lalescu on April 29, 2025, 06:10:10 PM
The snapshot: https://lalescu.ro/liviu/Backup-fet/ (get the latest snapshot, always, I might put more files there).

Please confirm it is OK now.
Title: Re: Separate hours' names and long names by a new line
Post by: Željko Vrabec on May 01, 2025, 12:03:16 AM
Hi Liviu!

All is ok now. I confirm!
Title: Re: Separate hours' names and long names by a new line
Post by: Liviu Lalescu on May 01, 2025, 07:24:44 AM
Thank you, Zeljko!
Title: Re: Separate hours' names and long names by a new line
Post by: Liviu Lalescu on May 04, 2025, 12:47:34 PM
I am sorry that I cannot correct this bug right away, but I am not home and the internet here is bad. Also, I prefer to compile on my desktop the Windows and GNU/Linux versions.

I hope to release the version FET-7.1.9 on Friday, 9 May 2025. Anyway, thankfully, the bug is minor.
Title: Re: Separate hours' names and long names by a new line
Post by: Željko Vrabec on May 04, 2025, 08:02:09 PM
Hi Liviu!

No need to hurry. Snapshot version solves my problem. Few months ago I made custom css based on features of the fet version that was up to date back then. In that css i style header of the table based on linebreak. That's why I needed this feature back.


Speaking of which, is there any plan to clear html structure?  :)
Title: Re: Separate hours' names and long names by a new line
Post by: Liviu Lalescu on May 05, 2025, 06:50:49 AM
It is Volker's responsibility :)

And how would you suggest to clear it?
Title: Re: Separate hours' names and long names by a new line
Post by: Željko Vrabec on May 05, 2025, 09:02:16 AM
Title: Re: Separate hours' names and long names by a new line
Post by: Liviu Lalescu on May 05, 2025, 09:09:33 AM
Thank you for your suggestions, Zeljko! I will add these in the TODO, also asking @Volker Dirr to have a look and tell me what he thinks. Volker, if these are easy to do changes, maybe you could be ready before the hopefully Friday FET release?

Zeljko, I am not sure about your point 2., because Volker did this because some programs did not handle correctly this tfoot. Again, I need Volker's advice and maybe code.
Title: Re: Separate hours' names and long names by a new line
Post by: Volker Dirr on May 05, 2025, 01:28:41 PM
Yes and no.

About 1: Your example is not valid html 5. You forgot the lang attribute.
But yes, I can change the header easy to valid html 5. But you won't see difference in a web browser. It will still look the same.

About 2: No, that is not possible. If you see the source, then you will notice that it is already written in the source many years ago. We use that foot workaround, because Qt doesn't support tfoot. Even not in Qt 6.9. See https://doc.qt.io/qt-6/richtext-html-subset.html
So we might only support it, if we keep the old style for the Qt Interface and code an new /optional variant for the export. But in my opinion it doesn't make much sense to do that.
Title: Re: Separate hours' names and long names by a new line
Post by: Liviu Lalescu on May 05, 2025, 01:38:18 PM
Volker, you are the person deciding the HTML stuff in FET. So, should I only add in the TODO?
Title: Re: Separate hours' names and long names by a new line
Post by: Volker Dirr on May 05, 2025, 01:49:27 PM
About 2: I think to much work to support both at the same time. In fact the workaround is also not "wrong". It only mean that the foot will not repeated if you print a single table on a second (or more) sheet(s). In fact i guess it is even "good" to not repeat it, since I don't think people will only print it and put it into a binder. I guess most guys will cut it, fix it together and paste it on the wall. In that case repeating is even "bad".

About 1: HTML 5 is now a bit over 10 years old. I guess nearly all guys should have web browsers now that can read HTML 5. It will be easy to it. I will do it tonight or on Wednesday. Please upload the latest snapshot of FET if you haven't done that already. (Is there a newer one than https://lalescu.ro/liviu/Backup-fet/fet-7.1.9-snapshot-29-apr-2025-19_58.tar.bz2 ? )
Title: Re: Separate hours' names and long names by a new line
Post by: Liviu Lalescu on May 05, 2025, 01:55:24 PM
Great! It is the latest snapshot, and I think I won't have anything to change to it (apart from the TODO, where I will add the point (2) from Zeljko, and from the ChangeLog).

Please don't forget also about the statistics HTML.
Title: Re: Separate hours' names and long names by a new line
Post by: Volker Dirr on May 05, 2025, 08:22:47 PM
I started coding. Changes of 1) are done.

Sadly some more changes are needed with html 5.
<br /> should be written as <br> now. I done that already now.

The bad thing is, that border="1" in table is not allowed anymore with html 5. Must be done by css. I thought I done it, but it doesn't work correct (especially, because I can't do it like that in the interface).

A lot of variants must be also tested. Especially export to hard disc, printing from the interface and also different fet html level settings (since level 0 is without css file, but the others are with css file).
Also the indexes are wrong now with html 5, since valign and halign are not allowed anymore in html, must be done with css. Will be a bit more "tricky", since we need to do it only in the index files, not in the other files.

I sent you my current work by email. I can't code more today or tomorrow. I can code more on Wednesday.
Title: Re: Separate hours' names and long names by a new line
Post by: Liviu Lalescu on May 12, 2025, 10:45:28 AM
Dear Zeljko,

Volker and I, we tried to convert/simplify to HTML 5, as you proposed, but it is complicated and risky now. Volker also met probably a Qt bug which doesn't allow us to do this upgrade. So, your suggestion will remain in the TODO for now.
Title: Re: Separate hours' names and long names by a new line
Post by: Željko Vrabec on May 14, 2025, 02:35:03 PM
Hi Liviu!

It's not urgent at all. HTML4 works fine as well. It was just a suggestion.
Title: Re: Separate hours' names and long names by a new line
Post by: Liviu Lalescu on May 14, 2025, 03:34:52 PM
Thank you for the suggestion! :)