Main Menu

typo in source code

Started by locutusofborg, September 10, 2015, 10:10:16 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

locutusofborg

Hi Guys, I would like to report some typos in the source code  :)

I: fet: spelling-error-in-binary usr/bin/fet adviced advised
N:
N:    Lintian found a spelling error in the given binary. Lintian has a list
N:    of common misspellings that it looks for. It does not have a dictionary
N:    like a spelling checker does.
N:   
N:    If the string containing the spelling error is translated with the help
N:    of gettext or a similar tool, please fix the error in the translations
N:    as well as the English text to avoid making the translations fuzzy. With
N:    gettext, for example, this means you should also fix the spelling
N:    mistake in the corresponding msgids in the *.po files.
N:   
N:    You can often find the word in the source code by running:
N:   
N:     grep -rw <word> <source-tree>
N:   
N:    This tag may produce false positives for words that contain non-ASCII
N:    characters due to limitations in strings.
N:   
N:    Severity: minor, Certainty: wild-guess
N:   
N:    Check: binaries, Type: binary, udeb
N:
I: fet: spelling-error-in-binary usr/bin/fet splitted split
I: fet: spelling-error-in-binary usr/bin/fet explicitely explicitly
I: fet: spelling-error-in-binary usr/bin/fet-cl adviced advised


and another issue:
I: fet: desktop-entry-lacks-keywords-entry usr/share/applications/fet.desktop
N:
N:    This .desktop file does either not contain a "Keywords" entry or it does
N:    not contain any keywords not already present in the "Name" or
N:    "GenericName" entries.
N:   
N:    .desktop files are organized in key/value pairs (similar to .ini files).
N:    "Keywords" is the name of the entry/key in the .desktop file containing
N:    keywords relevant for this .desktop file.
N:   
N:    The desktop-file-validate tool in the desktop-file-utils package is
N:    useful for checking the syntax of desktop entries.
N:   
N:    Refer to
N:    http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html,
N:    https://bugs.debian.org/693918, and
N:    https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords for
N:    details.
N:   
N:    Severity: wishlist, Certainty: certain
N:   
N:    Check: menu-format, Type: binary
N:

you can see them here http://debomatic-amd64.debian.net/distribution#unstable/fet/5.27.8-1/lintian

and google for the lintian warning to see the extended description :)

let me know if you need help!

cheers,

Gianfranco (who just uploaded the new fet on Debian)

Liviu Lalescu

#1
Thank you!

Could you send me a corrected .desktop file? I don't know how to add keywords.

I think I will correct typos and hopefully release a new version soon.

Edited to add: should I add keywords for all the languages listed under Name and Comments? I don't know how to do that. Also, I don't know what other keywords to add besides the Name and Comments words.

Liviu Lalescu

If you can, please check the latest snapshot on http://lalescu.ro/liviu/Backup-fet/ and tell me if I solved the typos.


Liviu Lalescu

Yes, but I cannot let it empty. In this case, I don't know what more keywords different from Name and Comments to add. Also, I cannot add keywords in other languages.

AlexL

Keywords=education,student,school,pupil,time,table
.etc.

Liviu Lalescu

Maybe these: education, teacher, student, school, high-school, university (maybe only the first three).

But how to add the translation of these into other languages (like in the attached file)? Add only the default US English?

Volker Dirr

maybe:
timetable, schedule, planning, school, high-school, university, education, teacher, students, principal

AlexL

Quote from: Liviu Lalescu on September 10, 2015, 07:18:53 PM
But how to add the translation of these into other languages (like in the attached file)?
Translators will translate later.
Quote from: Liviu Lalescu on September 10, 2015, 07:18:53 PM
Add only the default US English?
Yes

locutusofborg

Sorry, the desktop file actually comes from Debian, not from Upstream... :)

https://anonscm.debian.org/cgit/collab-maint/fet.git/tree/debian/fet.desktop

well you might want to start from there and add some english keywords...
(not too many, just 4-5 keywords are fine!)

thanks a lot!

Liviu Lalescu

OK, I added some keywords, please check the attached file.

locutusofborg


Liviu Lalescu

Thank you for your bug reports!

I will release a new version, but I don't know how soon. Now it is a kind of critical period, many users are downloading and using before school start.

Maybe you could test the new version (from the link above: http://lalescu.ro/liviu/Backup-fet/ , and replace fet.desktop with the file from my previous post) to check that the warnings are gone. But only if you have enough spare time.

locutusofborg

actually I can wait for the new release, they aren't important warnings, and the version is not even in Debian unstable
(it is in the new queue)

cheers!

G.

Liviu Lalescu

I have released the new version. Thank you for your reports!