typo in source code

[locutusofborg]

Updating it right now, thanks!

[Volker Dirr]

Does it compile amd64 only. I couldn't find it in i386. (maybe it just need some time?)

I also wonder about the building log file:
dpkg-gencontrol: warning: File::FcntlLock not available; using flock which is not NFS-safe

What does that mean? (I saw it while compiling and viewing the log.)

[Volker Dirr]

hmmm... I can see this:

6m27.2s ERROR: Installation of fet failed
6m27.2s ERROR: Installation of fet-data failed
6m27.2s ERROR: Could not install fet-data fet.
6m30.3s ERROR: piuparts run ends.

Is there somewhere more information? I don't know how to fix that.

[Volker Dirr]

In the detailed build log are some more warnings. Any idea how to fix them?

dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/fet/usr/bin/fet debian/fet/usr/bin/fet-cl were not linked against libpthread.so.0 (they use none of the library's symbols)
dpkg-gencontrol: warning: File::FcntlLock not available; using flock which is not NFS-safe
dpkg-genchanges: warning: 'since' option specifies non-existing version
dpkg-genchanges: warning: use newest entry that is earlier than the one specified

[Volker Dirr]

I saw you recompiled. Looks better now (less warnings). I hope you can fix also the other warnings. Maybe, after you are successful and if you have a bit time, let me know how you use Deb-o-Matic and how you solved the warnings.

[locutusofborg]

Hi, nothing to worry about, DebOMatic is a service where we upload build tries, so I did just upload a version for testing on amd64.

I uploaded right now a new version, that will be likely be the one in the archive.

Piuparts seems to be giving a problem in -data package, but I guess this is a false positive

the only real warning is:
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/fet/usr/bin/fet debian/fet/usr/bin/fet-cl were not linked against libpthread.so.0 (they use none of the library's symbols)

I guess you want to fix it, you link pthread but you don't use symbols of it.

You use QThread, and it should already link threads internal
(or I could use wl-asneeded flag to strip it )

[Liviu Lalescu]

I did as in the attached files, maybe you can test: overwrite and compile again. But I am not sure this will solve the warning, as fet and fet-cl still require threading.

[Volker Dirr]

Maybe the problem is in generation.cpp.

stuff like
extern QMutex myMutex;

is used by fet, but not fet-cl.

so that stuff must not be compiled with fet-cl?!

[locutusofborg]

I don't know, the patch doesn't solve the issue, but we can just not care, it is a useless warning, and the package is already in the new queue

[Liviu Lalescu]

I don't know, the patch doesn't solve the issue, but we can just not care, it is a useless warning, and the package is already in the new queue

OK, sure.