fet-5.32.0 Compile error on Mac os 10.6 Qt 4.8

[Valdo]

Ok this is the error:

interface/timetableviewstudentstimehorizontalform.h:51: error: expected ';' before 'override'
interface/timetableviewstudentstimehorizontalform.h:60: error: ISO C++ forbids initialization of member 'MINIMUM_WIDTH_SPIN_BOX_VALUE'
interface/timetableviewstudentstimehorizontalform.h:60: error: making 'MINIMUM_WIDTH_SPIN_BOX_VALUE' static
interface/timetableviewstudentstimehorizontalform.h:61: error: ISO C++ forbids initialization of member 'MINIMUM_HEIGHT_SPIN_BOX_VALUE'
interface/timetableviewstudentstimehorizontalform.h:61: error: making 'MINIMUM_HEIGHT_SPIN_BOX_VALUE' static
In file included from interface/fet.cpp:64:
interface/timetableviewteacherstimehorizontalform.h:44: error: expected ';' before 'override'
interface/timetableviewteacherstimehorizontalform.h:53: error: ISO C++ forbids initialization of member 'MINIMUM_WIDTH_SPIN_BOX_VALUE'
interface/timetableviewteacherstimehorizontalform.h:53: error: making 'MINIMUM_WIDTH_SPIN_BOX_VALUE' static
interface/timetableviewteacherstimehorizontalform.h:54: error: ISO C++ forbids initialization of member 'MINIMUM_HEIGHT_SPIN_BOX_VALUE'
interface/timetableviewteacherstimehorizontalform.h:54: error: making 'MINIMUM_HEIGHT_SPIN_BOX_VALUE' static
make[1]: *** [../tmp/gui/fet.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [sub-src-src-pro-make_default] Error 2
Macintosh:fet-5.32.0 alberto$


but no problem I use 5.31.9 

[Liviu Lalescu]

It seems it is a C++ compiler problem, not Qt.

I am trying now to fix these problems and I'll let you know. Should be easy to fix.

[rodolforg]

override keyword is for c++ 11. Just remove it.

[Liviu Lalescu]

Thank you for your advice, rodolforg! I will, after I read a bit about it. I just wrote it similar to a Qt example.

The other problems are very easy to fix.

Valdo, I think I will put a snapshot for you very soon, so please stay tuned and let me know if it will work.

[Liviu Lalescu]

Valdo, I added a new snapshot on http://lalescu.ro/liviu/fet/download/test/ , please report to me as soon as possible if it is now compiling and working correctly for you.

[Valdo]

Perfect, now compile and run are ok.
The new horizontal timetable is ok, only slow when lock or unlock and switch students and subjects.

thank you so much 

[Liviu Lalescu]

Thank you for the report!

It should not be slow. On my computer it is not, and I have a 10 year old AMD 2.1 GHz. It takes less than 0.5 seconds.

Could you please send me here or privately (by email) your input file, so I can check the problem?

[Liviu Lalescu]

I added a new snapshot, with a minor code change (no functionality changes). Could you please verify if it compiles OK on your old Qt 4 computer?

The same link: http://lalescu.ro/liviu/fet/download/test/

[Volker Dirr]

hmm... Qt 4 is obsolete a long time now. we should think about skipping support for old Qt versions, old compilers and old OS.
(Also MaxOS 10.6 is pretty old. It has got a lot of security holes that won't be fixed anymore (last security fix was published 2013. It is very unclever to use such an old OS. There are a lot of known security problem with that OS. You should update to a newer one.)

[Liviu Lalescu]

You are right, Volker, but if it is easy to keep backwards compatibility, why don't keep it?

[Zsolt Udvari]

Qt 4 is obsolete a long time now

I think it isn't Qt4-specific bug. On FreeBSD 10.3 can build it with Qt4.

[Volker Dirr]

No, as i can see it was/is old compiler problem. But in my opinion we should skip support of obsolete Qt, Compiler and OS. Not just the "current problematic" one. At least after some time.

[Liviu Lalescu]

Valdo, I released the new official version, FET-5.32.1. Thank you for your report!

[Valdo]

Compile and run - both Mac OS 10.6.8 qt 4.8 and Mac OS 10.12.6 qt 5.5 - all ok.

Thank

[Liviu Lalescu]