OLD - FET-5.23.3 snapshot for testing

Started by Liviu Lalescu, September 19, 2014, 08:38:12 PM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Liviu Lalescu

I have put a new snapshot on http://lalescu.ro/liviu/fet/download/test/ (the usual location). Only tar.bz2 for now.

The ChangeLog:

   - Added a fet.desktop file (by Alexey Loginov).
   - Fixed some comments concerning the GNU GPL license (reported by Alexey Loginov).
   - Added a "make install" option (suggested by Alexey Loginov).

Please help testing these. Test "make install" on your system (with "sudo"), then "make uninstall" (again with "sudo"). Check the locations /usr/share/fet/translations/, /usr/share/applications/fet.desktop, /usr/share/doc/fet/, usr/share/man/man1/, /usr/bin/, /usr/share/fet/examples/. After uninstall, everything is OK, the only remaining empty directory is /usr/share/fet/ (can this removed also automatically?) Check the fet.pro file (which is using qmake options for this). Have I forgot/mistaken anything?

Later edit: I found a trick and also /usr/share/fet/ is removed after "make uninstall". But I need to deploy all the translations directory, including unnecessary .ts files.

Zsolt Udvari

I don't know about qmake rules, but is it possible to set the paths? On FreeBSD the packages will install into /usr/local (as in the autoconf tools the PREFIX variable).

Oh, yes, is it possible:
executables.path ?= /usr/bin
So please add a question mark before equal sign (all path not only executables) :)
In this case if user run qmake-qt4 without arguments the paths will be the default but when run with qmake-qt4 executables.path=/usr/local/bin the executables path will be /usr/local/bin.

INSTALLS: there is an INSTALLS += line in fet.pro. Before this line INSTALLS has some value? Would be nice INSTALLS ?= same above because fet-port has options to install examples or translations. And maybe a plus "option" to avoid to build fet (and build only fet-cl, see port's ONLYCL option) via SUBDIRS.

Zsolt Udvari

I've modified fet.pro, please check. And if it's okay, should update "install" section in README.

TEMPLATE = subdirs
isEmpty(DISABLEGUI) {
    USUBDIRS = src/src.pro src/src-cl.pro
} else {
    USUBDIRS = src/src-cl.pro
}
SUBDIRS += $$USUBDIRS
message($$SUBDIRS)

isEmpty(PREFIX) {
    PREFIX=/usr
}

isEmpty(translations.path) {
    translations.path = $$PREFIX/share/fet
}
translations.files = translations/

isEmpty(desktop.path) {
    desktop.path = $$PREFIX/share/applications
}
desktop.files = fet.desktop

isEmpty(documentation.path) {
    documentation.path = $$PREFIX/share/doc/fet
}
documentation.files = doc/* AUTHORS COPYING ChangeLog README REFERENCES THANKS TODO TRANSLATORS

isEmpty(manual.path) {
    manual.path = $$PREFIX/share/man/man1
}
manual.files = man/*

isEmpty(executables.path) {
    executables.path = $$PREFIX/bin
}
isEmpty(DISABLEGUI) {
    executables.files = fet fet-cl
} else {
    executables.files = fet-cl
}

isEmpty(examples.path) {
    examples.path = $$PREFIX/share/fet
}
examples.files = examples/

INSTALLS += translations desktop manual documentation executables examples
INSTALLS -= $$EXCLUDEINSTALL

Liviu Lalescu

#3
Thank you, Zsolt, but unfortunately I used you last script and there are problems. The only problem of "make install" is that it does not copy "fet-cl" into "/usr/bin/". The problems of "make uninstall" are that it tries to remove "/usr/share/applications/", "/usr/share/man/man1/", and "/usr/bin/".

I am using openSuse 13.1. I attach my Makefile.


Liviu Lalescu

I investigated further. It might be a Qt bug. It seems that even with my variant the bugs appear. I just switched to Qt 5.3.2. The fact that fet-cl is not copied appears if you compile from scratch. If you hit "make" after one successful compilation, the bug is no longer present (and the executables are also stripped).

Zsolt Udvari

I didn't ever used Qt and *.pro files. I've read manual and seen these possibilities, I've tested (only create Makefile) and it seemed it worked (generating Makefile).

make uninstall: does anybody use? :)

AlexL

#6
Hello, Liviu,
1) missing picture for desktop file ( http://svnweb.mageia.org/packages/cauldron/fet/current/SOURCES/fet.xpm?view=co ), to put into /usr/share/pixmaps/
2) it's enough to install only *.qm without *.ts
3) Will you implement autodetect language while the first run for fet?
4)  invalid-desktopfile (you should move Enter):
Comment[el]=Δημιουργήστε προγράμματα διδακτικών ωρών για εκπαιδευτικά
ιδρύματα
->
Comment[el]=Δημιουργήστε προγράμματα διδακτικών ωρών για εκπαιδευτικά ιδρύματα

Comment[pl]=Generuje plany zajęć, rozkłady i grafiki dla instytucji
edukacyjnych
->
Comment[pl]=Generuje plany zajęć, rozkłady i grafiki dla instytucji edukacyjnych
fet.i586: W: invalid-desktopfile /usr/share/applications/fet.desktop file contains line "ιδρύματα", which is not a comment, a group or an entry
fet.i586: W: invalid-desktopfile /usr/share/applications/fet.desktop file contains line "edukacyjnych", which is not a comment, a group or an entry

Volker Dirr

In my opinion make uninstall must work (perfect). Some guys like to do that if they update a package.

About the icon: Maybe we should use the "official" icons?

AlexL

You needs fet.xpm for Debian anyway, but you can add other icons. If you have svg, then put into /usr/share/icons/hicolor/scalable/apps/, for png: into /usr/share/pixmaps/

Volker Dirr

Ah. ok. Thank you for that information.
Looks like Gimp can export into xpm, so there shouldn't be a problem to generate that.
Do you know a link to some information about the needed xpm by Debian? (for example needed width and high?)

AlexL

#10
http://ftp.br.debian.org/debian/pool/main/f/fet/
fet_5.22.0-0.1.diff.gz
fet-5.22.0/debian/fet.xpm
48*48
It was imported from Debian into Mageia Linux: http://svnweb.mageia.org/packages/cauldron/fet/current/SOURCES/fet.xpm?view=co

Liviu Lalescu

#11
Zsolt, thank you very much! It was a problem because the target files are not available before compiling. So I added install information about fet and fet-cl in src.pro and src-cl.pro. It works now. Also "make uninstall" should work.

Alex, thank you very much! :

1) I created two pictures, please check; I preferred a .svg and a .png;

2) I only install *.qm;

3) I cannot do that: many languages are incompletely/badly translated.

4) Corrected, thanks!

I have just put a new snapshot on the same usual location, http://lalescu.ro/liviu/fet/download/test/ . Please let me know.

I'll compile now for Windows and put a new version.

The icon is subject to change, if anybody has the courage to challenge my extraordinary drawing talent :))

Edited to add: I added also the Windows executable.

AlexL

#12
Translations were not installed.
You can reproduce: make install INSTALL_ROOT=/path/dir

fet.i586: W: no-manual-page-for-binary fet-cl

Liviu Lalescu

#13
Quote from: AlexL on September 20, 2014, 09:24:18 PM
Translations were not installed.
You can reproduce: make install INSTALL_ROOT=/path/dir

Translations need to be in /usr/share/fet/translations/ , always. This is where FET executable searches for them. Maybe you could tell me how to correct this.

Quote
fet.i586: W: no-manual-page-for-binary fet-cl

I'll try to make a manual page for fet-cl.

Zsolt Udvari

Quote from: Liviu Lalescu on September 21, 2014, 07:27:19 AM
Translations need to be in /usr/share/fet/translations/ , always. This is where FET executable searches for them. Maybe you could tell me how to correct this.
Maybe can you set from fet.pro (translations.path)? Maybe this helps.